Add test for error propagation. #120
Conversation
| // FIXME this test should look for a propagated error such as | ||
| // PROOF_GENERATION_ERROR |
There was a problem hiding this comment.
Is this fixable before we merge this one?
There was a problem hiding this comment.
we need to inform the implementers that they need to start returning error objects when issuance fails and verification fails. Currently most implementers do return verification results. Basically we need to make implementers aware that https://w3c-ccg.github.io/vc-api/#error-handling VC-API Error Handling is a thing. I also thought the VC-API group came to consensus at some point about standardized error handling, but it looks like they have not although error codes in the specs do suggest there is a common error object for data integrity at least. So perhaps we should ask implementers for the test suite to return https://w3c.github.io/vc-data-integrity/#processing-errors Problem Details in the future. Basically right now we not have informed implementers to return problem details so asserting on those error codes in data returned on fail seems unfair. I can add a section to the README about this as we really need those problem details for the suite.
There was a problem hiding this comment.
@BigBlueHat revised README is here: #122
Those details should probably be in the implementations README to.
There was a problem hiding this comment.
this is the PR that defines it, ideally there would be a problemDetails property in the response and we just need to ensure there's at least 1 item in that array, since there's no instruction on what to look for in that statement.
Adds a new statement about error propagation in the create step: